Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes "InvalidOperationException" errors by performing async operations in SemaphoreSlim #796

Merged
merged 20 commits into from
Nov 19, 2020
Merged

Fixes "InvalidOperationException" errors by performing async operations in SemaphoreSlim #796

merged 20 commits into from
Nov 19, 2020

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Nov 13, 2020 •
edited
Loading

Fixes #459 #54 #786 #792
Rework over PR #579 with helpful ideas from @roji and @DavoudEshtehari

This PR fixes the issue where below exception would occur randomly due to SslStream.WriteAsync collisions.

System.InvalidOperationException: Invalid operation. The connection is closed.
   at Microsoft.Data.SqlClient.TdsParserStateObject.WritePacket(Byte flushMode, Boolean canAccumulate)

The design change introduces use of SemaphoreSlim with SNISslStream and SNINetworkStream overrides to ensure only 1 task is allowed to read/write to stream asynchronously at a time.

Not fixed in this issue

@cheenamalhotra cheenamalhotra changed the title Fixes "InvalidOperationException" errors by performing async write operations in Semaphore Concurrent Queue Fixes "InvalidOperationException" errors by performing async operations in Semaphore Concurrent Queue Nov 13, 2020
@cheenamalhotra cheenamalhotra mentioned this pull request Nov 13, 2020
Closed
@cheenamalhotra cheenamalhotra added this to the 2.1.0 milestone Nov 13, 2020
This was linked to issues Nov 13, 2020
"The connection is closed" errors in System.Data.SqlClient on Linux without MARS. #54
Closed
InvalidOperationException when writing a lot of packets asynchronously and using managed SNI implementation #786
Closed
Queries with many Guids in Linux: System.InvalidOperationException: Invalid operation. The connection is closed. #792
Closed
@cheenamalhotra cheenamalhotra mentioned this pull request Nov 13, 2020
Closed
@cheenamalhotra cheenamalhotra added the 📈 Performance Issues that are targeted to performance improvements. label Nov 17, 2020
@cheenamalhotra cheenamalhotra mentioned this pull request Nov 17, 2020
Closed
@cheenamalhotra cheenamalhotra changed the title WIP: Fixes "InvalidOperationException" errors by performing async operations in Semaphore Concurrent Queue Fixes "InvalidOperationException" errors by performing async operations in Semaphore Concurrent Queue Nov 18, 2020
@cheenamalhotra cheenamalhotra changed the title Fixes "InvalidOperationException" errors by performing async operations in Semaphore Concurrent Queue Fixes "InvalidOperationException" errors by performing async operations in SemaphoreSlim Nov 18, 2020
@DavoudEshtehari DavoudEshtehari mentioned this pull request Nov 19, 2020
Open
@cheenamalhotra cheenamalhotra merged commit cde615e into dotnet:master Nov 19, 2020
@Charles-Gagnon Charles-Gagnon mentioned this pull request Nov 20, 2020
Merged
@cheenamalhotra cheenamalhotra mentioned this pull request Nov 23, 2020
Closed
@cheenamalhotra cheenamalhotra mentioned this pull request Feb 16, 2021
Closed
This was referenced Mar 8, 2021
Closed
Closed
@CobeLapierre CobeLapierre mentioned this pull request May 19, 2021
Closed
@cheenamalhotra cheenamalhotra mentioned this pull request Jun 17, 2021
Merged
@Charles-Gagnon Charles-Gagnon mentioned this pull request Sep 20, 2021
Merged
@radekfojtik radekfojtik mentioned this pull request Feb 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karinazhou karinazhou karinazhou left review comments

@David-Engel David-Engel David-Engel left review comments

@Wraith2 Wraith2 Wraith2 left review comments

@martyt martyt martyt left review comments

@roji roji roji left review comments

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

@JRahnama JRahnama Awaiting requested review from JRahnama

@johnnypham johnnypham Awaiting requested review from johnnypham

Assignees
No one assigned
Labels
📈 Performance Issues that are targeted to performance improvements.
Projects
None yet
Milestone
2.1.0
7 participants
@cheenamalhotra @roji @martyt @Wraith2 @David-Engel @karinazhou @DavoudEshtehari